GFS2: Remove unnecessary memory barrier
authorBob Peterson <rpeterso@redhat.com>
Thu, 25 Jul 2013 13:53:49 +0000 (09:53 -0400)
committerSteven Whitehouse <swhiteho@redhat.com>
Wed, 4 Sep 2013 14:58:21 +0000 (15:58 +0100)
Function test_and_clear_bit implies a memory barrier, so subsequent
memory barriers are unnecessary.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/glock.c

index ce7078d5aa9787ac1a8ef9dd3798aef2db73de21..722329cac98fc9afb1f323ba8cf6a6306068457c 100644 (file)
@@ -1411,7 +1411,6 @@ __acquires(&lru_lock)
                if (demote_ok(gl))
                        handle_callback(gl, LM_ST_UNLOCKED, 0, false);
                WARN_ON(!test_and_clear_bit(GLF_LOCK, &gl->gl_flags));
-               smp_mb__after_clear_bit();
                if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0)
                        gfs2_glock_put_nolock(gl);
                spin_unlock(&gl->gl_spin);