batman-adv: Drop immediate batadv_hardif_neigh_node free function
authorSven Eckelmann <sven@narfation.org>
Tue, 5 Jan 2016 11:06:23 +0000 (12:06 +0100)
committerAntonio Quartulli <a@unstable.cc>
Sat, 16 Jan 2016 14:49:28 +0000 (22:49 +0800)
commitf63896928760a7c3ce9c5d3f882ba9f10ae73ad0
tree652dc676ac758b7736816be9c1f182191a8bb121
parent2baa753c276f27f8e844637561ad597867aa6fb6
batman-adv: Drop immediate batadv_hardif_neigh_node free function

It is not allowed to free the memory of an object which is part of a list
which is protected by rcu-read-side-critical sections without making sure
that no other context is accessing the object anymore. This usually happens
by removing the references to this object and then waiting until the rcu
grace period is over and no one (allowedly) accesses it anymore.

But the _now functions ignore this completely. They free the object
directly even when a different context still tries to access it. This has
to be avoided and thus these functions must be removed and all functions
have to use batadv_hardif_neigh_free_ref.

Fixes: cef63419f7db ("batman-adv: add list of unique single hop neighbors per hard-interface")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
net/batman-adv/originator.c