Revert "net: thunderx: Add support for xdp redirect"
authorJesper Dangaard Brouer <brouer@redhat.com>
Tue, 13 Feb 2018 16:59:22 +0000 (17:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Feb 2018 19:23:39 +0000 (14:23 -0500)
commite6dbe9397ea754e80f59d852a74fc289fa8b0f3a
tree08dc24317281e795f1abb0d49fe15bed5d484103
parentfae8b6f4a6be42372f8b7ffda39c3ca2cd951dc1
Revert "net: thunderx: Add support for xdp redirect"

This reverts commit aa136d0c82fcd6af14535853c30e219e02b2692d.

As I previously[1] pointed out this implementation of XDP_REDIRECT is
wrong.  XDP_REDIRECT is a facility that must work between different
NIC drivers.  Another NIC driver can call ndo_xdp_xmit/nicvf_xdp_xmit,
but your driver patch assumes payload data (at top of page) will
contain a queue index and a DMA addr, this is not true and worse will
likely contain garbage.

Given you have not fixed this in due time (just reached v4.16-rc1),
the only option I see is a revert.

[1] http://lkml.kernel.org/r/20171211130902.482513d3@redhat.com

Cc: Sunil Goutham <sgoutham@cavium.com>
Cc: Christina Jacob <cjacob@caviumnetworks.com>
Cc: Aleksey Makarov <aleksey.makarov@cavium.com>
Fixes: aa136d0c82fc ("net: thunderx: Add support for xdp redirect")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cavium/thunder/nicvf_main.c
drivers/net/ethernet/cavium/thunder/nicvf_queues.c
drivers/net/ethernet/cavium/thunder/nicvf_queues.h