xfrm: Fix null pointer dereference when decoding sessions
authorSteffen Klassert <steffen.klassert@secunet.com>
Wed, 30 Oct 2013 10:16:28 +0000 (11:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Dec 2013 15:29:15 +0000 (07:29 -0800)
commitd13252b415a1de2b91d240195afc7fd917c1f148
tree536ebc9e869b572d994f5351f79449e309d505c9
parent83fc70f416f604cb71315de467accd0c07450c12
xfrm: Fix null pointer dereference when decoding sessions

[ Upstream commit 84502b5ef9849a9694673b15c31bd3ac693010ae ]

On some codepaths the skb does not have a dst entry
when xfrm_decode_session() is called. So check for
a valid skb_dst() before dereferencing the device
interface index. We use 0 as the device index if
there is no valid skb_dst(), or at reverse decoding
we use skb_iif as device interface index.

Bug was introduced with git commit bafd4bd4dc
("xfrm: Decode sessions with output interface.").

Reported-by: Meelis Roos <mroos@linux.ee>
Tested-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/xfrm4_policy.c
net/ipv6/xfrm6_policy.c