kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd
authorSuzuki K Poulose <suzuki.poulose@arm.com>
Mon, 3 Apr 2017 14:12:43 +0000 (15:12 +0100)
committerJiri Slaby <jslaby@suse.cz>
Tue, 9 May 2017 06:19:39 +0000 (08:19 +0200)
commitc3c936aa02581ccd90eac393765c45258b385b11
tree2ce196bf89e29e06cc8d2dbec2a9d8e23cb8d64b
parent64b69f5bfad4f66b2d4e0461ca3ef8a0908fe080
kvm: arm/arm64: Fix locking for kvm_free_stage2_pgd

commit 8b3405e345b5a098101b0c31b264c812bba045d9 upstream.

In kvm_free_stage2_pgd() we don't hold the kvm->mmu_lock while calling
unmap_stage2_range() on the entire memory range for the guest. This could
cause problems with other callers (e.g, munmap on a memslot) trying to
unmap a range. And since we have to unmap the entire Guest memory range
holding a spinlock, make sure we yield the lock if necessary, after we
unmap each PUD range.

[skp] provided backport for 3.12

Fixes: commit d5d8184d35c9 ("KVM: ARM: Memory virtualization setup")
Cc: Paolo Bonzini <pbonzin@redhat.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
[ Avoid vCPU starvation and lockup detector warnings ]
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Christoffer Dall <cdall@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
arch/arm/kvm/mmu.c