[IrDA]: Correctly handling socket error
authorOlaf Kirch <olaf.kirch@oracle.com>
Thu, 19 Apr 2007 23:45:09 +0000 (01:45 +0200)
committerAdrian Bunk <bunk@stusta.de>
Thu, 19 Apr 2007 23:45:09 +0000 (01:45 +0200)
commitae0199ba95ac7d5f45a565afb4adf8bb1e7ef59c
tree5d7957e89206c6254e15ef1c67b83796fc43a49d
parent17acc02c4df45426d62e5e31231a2312c361f107
[IrDA]: Correctly handling socket error

This patch fixes an oops first reported in mid 2006 - see
http://lkml.org/lkml/2006/8/29/358 The cause of this bug report is that
when an error is signalled on the socket, irda_recvmsg_stream returns
without removing a local wait_queue variable from the socket's sk_sleep
queue. This causes havoc further down the road.

In response to this problem, a patch was made that invoked sock_orphan on
the socket when receiving a disconnect indication. This is not a good fix,
as this sets sk_sleep to NULL, causing applications sleeping in recvmsg
(and other places) to oops.

Signed-off-by: Olaf Kirch <olaf.kirch@oracle.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
net/irda/af_irda.c