ext3: Fix error handling on inode bitmap corruption
authorJan Kara <jack@suse.cz>
Thu, 8 Dec 2011 20:13:46 +0000 (21:13 +0100)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Mon, 10 Feb 2014 21:11:27 +0000 (16:11 -0500)
commit8a6682199359240e66450999a79ae7c66a95bb42
tree984b6e37f5ed80f8b0f8d49914f1644e349d1c74
parent8840b297ba5508ee30452e5b1a876a0dcd09708b
ext3: Fix error handling on inode bitmap corruption

commit 1415dd8705394399d59a3df1ab48d149e1e41e77 upstream.

When insert_inode_locked() fails in ext3_new_inode() it most likely
means inode bitmap got corrupted and we allocated again inode which
is already in use. Also doing unlock_new_inode() during error recovery
is wrong since inode does not have I_NEW set. Fix the problem by jumping
to fail: (instead of fail_drop:) which declares filesystem error and
does not call unlock_new_inode().

Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/ext3/ialloc.c