USB: serial: quatech2: fix use-after-free in probe error path
authorJohan Hovold <johan@kernel.org>
Sun, 8 May 2016 18:08:02 +0000 (20:08 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 6 Jun 2016 23:12:15 +0000 (19:12 -0400)
commit7124f5dfff7b22fd91546ce7dbf9e80b56f0d61f
treef662608e740dae5cecd9b77add09ced28914ca05
parent17e958ca3f508c361325688ab1da7144febb35fe
USB: serial: quatech2: fix use-after-free in probe error path

[ Upstream commit 028c49f5e02a257c94129cd815f7c8485f51d4ef ]

The interface read URB is submitted in attach, but was only unlinked by
the driver at disconnect.

In case of a late probe error (e.g. due to failed minor allocation),
disconnect is never called and we would end up with active URBs for an
unbound interface. This in turn could lead to deallocated memory being
dereferenced in the completion callback.

Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Cc: stable <stable@vger.kernel.org> # v3.5: 40d04738491d
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/usb/serial/quatech2.c