target: Don't override EXTENDED_COPY xcopy_pt_cmd SCSI status code
authorDinesh Israni <ddi@datera.io>
Tue, 11 Oct 2016 03:22:03 +0000 (20:22 -0700)
committerSasha Levin <alexander.levin@verizon.com>
Thu, 24 Nov 2016 02:53:18 +0000 (21:53 -0500)
commit6848fad2cbb5a1b86f1e39088ab1358a1ea81cfa
treef1c332f52cb4ba6af137617cf9e6956c03097cf4
parentc30d39a0de7c198ad6fd55403130b2d063b65312
target: Don't override EXTENDED_COPY xcopy_pt_cmd SCSI status code

[ Upstream commit 926317de33998c112c5510301868ea9aa34097e2 ]

This patch addresses a bug where a local EXTENDED_COPY WRITE or READ
backend I/O request would always return SAM_STAT_CHECK_CONDITION,
even if underlying xcopy_pt_cmd->se_cmd generated a different
SCSI status code.

ESX host environments expect to hit SAM_STAT_RESERVATION_CONFLICT
for certain scenarios, and SAM_STAT_CHECK_CONDITION results in
non-retriable status for these cases.

Tested on v4.1.y with ESX v5.5u2+ with local IBLOCK backend copy.

Reported-by: Nixon Vincent <nixon.vincent@calsoftinc.com>
Tested-by: Nixon Vincent <nixon.vincent@calsoftinc.com>
Cc: Nixon Vincent <nixon.vincent@calsoftinc.com>
Tested-by: Dinesh Israni <ddi@datera.io>
Signed-off-by: Dinesh Israni <ddi@datera.io>
Cc: Dinesh Israni <ddi@datera.io>
Cc: stable@vger.kernel.org # 3.14+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/target/target_core_xcopy.c