perf probe: Improve error messages in --line option
authorMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Fri, 6 Jun 2014 07:14:06 +0000 (07:14 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 10 Jun 2014 13:02:06 +0000 (10:02 -0300)
commit5ee05b8801892ecc5df44e03429008dfa89aa361
tree4eb394e88cba9b0ce07279f0c0ed085b0b3980d2
parent69e96eaa4fef04ad543eda3eab787dbae99d8912
perf probe: Improve error messages in --line option

Improve error messages of 'perf probe --line' mode.

Currently 'perf probe' shows the "Debuginfo analysis failed" message with
an error code when the given symbol is not found:

  -----
  # perf probe -L page_cgroup_init_flatmem
  Debuginfo analysis failed. (-2)
    Error: Failed to show lines.
  -----

But -2 (-ENOENT) means that the given source line or function was not
found. With this patch, 'perf probe' shows the correct error message:

  -----
  # perf probe -L page_cgroup_init_flatmem
  Specified source line is not found.
    Error: Failed to show lines.
  -----

There is also another debug error code is shown in the same function
after get_real_path(). This removes that too.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140606071406.6788.47850.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-event.c