nfsd: fix dentry refcounting on create
authorJosef Bacik <jbacik@fb.com>
Wed, 10 Aug 2016 18:46:27 +0000 (14:46 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 11 Aug 2016 15:42:08 +0000 (11:42 -0400)
commit502aa0a5be633e6558574ebcf63b65afdfbfcd7a
treef1998fcb7817d265fc5ac53fb21db03a80e0a6eb
parent29b4817d4018df78086157ea3a55c1d9424a7cfc
nfsd: fix dentry refcounting on create

b44061d0b9 introduced a dentry ref counting bug.  Previously we were
grabbing one ref to dchild in nfsd_create(), but with the creation of
nfsd_create_locked() we have a ref for dchild from the lookup in
nfsd_create(), and then another ref in nfsd_create_locked().  The ref
from the lookup in nfsd_create() is never dropped and results in
dentries still in use at unmount.

Signed-off-by: Josef Bacik <jbacik@fb.com>
Fixes: b44061d0b9 "nfsd: reorganize nfsd_create"
Reported-by: kernel test robot <xiaolong.ye@intel.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/vfs.c