bpf, x64: fix memleak when not converging after image
authorDaniel Borkmann <daniel@iogearbox.net>
Wed, 2 May 2018 18:12:22 +0000 (20:12 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 2 May 2018 19:35:47 +0000 (12:35 -0700)
commit3aab8884c9eb99189a3569ac4e6b205371c9ac0b
tree463a04b0982e85329b6dbec84ca8f9588661afaf
parenta4e21ff8d9a311b16cfa9e41aed0c627a47149a4
bpf, x64: fix memleak when not converging after image

While reviewing x64 JIT code, I noticed that we leak the prior allocated
JIT image in the case where proglen != oldproglen during the JIT passes.
Prior to the commit e0ee9c12157d ("x86: bpf_jit: fix two bugs in eBPF JIT
compiler") we would just break out of the loop, and using the image as the
JITed prog since it could only shrink in size anyway. After e0ee9c12157d,
we would bail out to out_addrs label where we free addrs and jit_data but
not the image coming from bpf_jit_binary_alloc().

Fixes: e0ee9c12157d ("x86: bpf_jit: fix two bugs in eBPF JIT compiler")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
arch/x86/net/bpf_jit_comp.c