cap_prctl: don't set error to 0 at 'no_change'
authorSerge E. Hallyn <serue@us.ibm.com>
Wed, 8 Apr 2009 21:55:58 +0000 (16:55 -0500)
committerChris Wright <chrisw@sous-sol.org>
Mon, 27 Apr 2009 17:36:59 +0000 (10:36 -0700)
commit22f45438e5e7369f7c3a384a41616affd200b840
tree988d222dca274fd261c1f90187fe73b104818f74
parentb76d2b612cd5c0c6fb82340f9ec241ca75b942f9
cap_prctl: don't set error to 0 at 'no_change'

upstream commit: 5bf37ec3e0f5eb79f23e024a7fbc8f3557c087f0

One-liner: capsh --print is broken without this patch.

In certain cases, cap_prctl returns error > 0 for success.  However,
the 'no_change' label was always setting error to 0.  As a result,
for example, 'prctl(CAP_BSET_READ, N)' would always return 0.
It should return 1 if a process has N in its bounding set (as
by default it does).

I'm keeping the no_change label even though it's now functionally
the same as 'error'.

Signed-off-by: Serge Hallyn <serue@us.ibm.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
security/commoncap.c