macsec: fix negative refcnt on parent link
authorSabrina Dubroca <sd@queasysnail.net>
Fri, 29 Jul 2016 13:37:55 +0000 (15:37 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 31 Jul 2016 04:11:08 +0000 (21:11 -0700)
commit0759e552bce7257db542e203a01a9ef8843c751e
tree93c36c2d45305788c3c869bd9d636dbaaa3a70f7
parent36b232c880c99fc03e135198c7c08d3d4b4f83ab
macsec: fix negative refcnt on parent link

When creation of a macsec device fails because an identical device
already exists on this link, the current code decrements the refcnt on
the parent link (in ->destructor for the macsec device), but it had not
been incremented yet.

Move the dev_hold(parent_link) call earlier during macsec device
creation.

Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macsec.c